Water Purifier Mod not preventing damage from murky water, have to unequip/re-equip

[f8isrippin]

Version

2.0

Platform

Windows

Every time I load up my game, I take damage from murky water but do not get sick. If I unequip the mod and re-equip the mod, or unequip and re-equip my helmet, it will start working normally again. It will then work for the rest of the session. If I leave and re-enter, the issue will still be present.

 

[ahawksfan]

I can confirm this is an issue on my game as well. Thanks for taking the time to post it.

 

[MasterKillerTC]

Can confirm as well, started after the upgrade

Windows 11

 

[cleio81]

can confirm. is this an intentional change? I sure hope not. kinda makes the water purifier mod useless.

 

[NekoPawtato]

Thank you for reporting. I see we have an internal ticket for this already so I've added this report to it.

 

[s_spowart]

I have this issue as well. I play with friends, and all friends have the same issue. We leave the water purifier on each of our helmets (sometimes 6 of us in session at once).
If we drink from a pond we take damage. Its like the water purifier doesnt exist.
Simply take the hat off even if keeping it in your hand, then drop it straight back on again and it will work for the rest of the session provided you dont log off and back on again at any point.

 

[bwestdpm9]

Thank you for reporting. I see we have an internal ticket for this already so I've added this report to it.

Have this exact same issue with multiplayer on PS5 console version as well…do you know if the ticket includes console version or is it all the same now? Thanks!

 

[valeskas]

This bug is not only about Water Purifier.
It affects anything relying on buffs applied at onSelfEquipStart on dedicated server.
For example Nerd Outfit without intellect mastery 3.
For example Impact Bracing.
For example Nerd Boots, Rogue Boots, Miner Boots, Raider Boots
Probably Bandolier, a bit tricky to check though.

The relevant buff simply vanishes on relog, which can be tested by changing hidden="true" to hidden="false"

The whole idea with binary buff/nobuff is flawed.
For example if I switch Nerd Outfit Q4 to Nerd Outfit Q5, is onSelfEquipStart of Q5 called before onSelfEquipStop of Q4? If so the buff will be silently overwritten first and deleted later and the thing will stop working without intellect mastery 3.
But some other item might want exactly that order - onSelfEquipStart of the new one before onSelfEquipStop of the old one.

 

[valeskas]

The whole idea with binary buff/nobuff is flawed.

On a second thought, the idea is fine. Expecting a onSelfEquipStop first, onSelfEquipStart second is reasonable.
Buffs obtained in these events should be just fixed to exist as expected.

 

[valeskas]

Investigated the issue under the debugger.

My guess is this:

The client on spawning does EntityBuffs.AddBuff in Equipment.Apply.
After that, in EntityAlive.switchModelView it reequips stuff, calling EntityBuffs.RemoveBuff, then EntityBuffs.AddBuff again.
EntityBuffs.RemoveBuff does not pass _instigatorId to server, so the server sends the event back, and the buff gets removed.
But EntityBuffs.AddBuff does pass _instigatorId to server, and server uses it to not send it back, so the buff does not get readded.
The passing back happens in NetPackageAddRemoveBuff.ProcessPackage.