Help a new modder out! Thanks!!

thatloopydude · Feb 9, 2020

My issue has been solved! Thank you to all that helped!!!!

I am adding new bullets to the game and wanting them to be unlocked via the sniper skill book tree, however the items won't unlock when the book is learned. The base ammo 50cal is unlocked by default and I can craft it. The 50capHP and 50calAP are locked. I can spawn the items in question via cm and use them in the gun. Just cant craft em. the Bundled version of all the versions are locked as well and are uncraftable.

Please help me out here... I've been at this for over 8 hours and I'm going to be bald before my genetics take part :miserable: :miserable: :miserable: :miserable: Link to paste.org

item.xml http://bit.ly/2ScMOKl

recipes.xml

Code:

&lt;LoopyBarrett&gt;
&lt;append xpath="recipes"&gt;



&lt;recipe name="Barrett M82" count="1" craft_area="workbench" tags="learnable,workbenchCrafting,perkDeadEye"&gt;
&lt;ingredient name="gunHuntingRifleParts" count="8"/&gt;
&lt;ingredient name="resourceForgedSteel" count="26"/&gt;
&lt;ingredient name="resourceDuctTape" count="14"/&gt;
&lt;ingredient name="resourceScrapPolymers" count="32"/&gt;
&lt;ingredient name="resourceSpring" count="12"/&gt;
&lt;effect_group&gt;
	&lt;passive_effect name="CraftingIngredientCount" level="1,6" operation="perc_add" value="0,5" tags="gunHuntingRifleParts,resourceForgedSteel,resourceDuctTape,resourceScrapPolymers,resourceSpring"/&gt;
&lt;/effect_group&gt;
&lt;/recipe&gt;



&lt;recipe name="50cal" count="1" craft_area="workbench" tags="workbenchCrafting"&gt;
&lt;ingredient name="resourceBulletTip" count="1"/&gt;
&lt;ingredient name="resourceGunPowder" count="5"/&gt;
&lt;ingredient name="resourceBulletCasing" count="1"/&gt;
&lt;/recipe&gt;

&lt;recipe name="Bundle50cal" count="1" craft_time="240" craft_area="workbench" tags="learnable,workbenchCrafting"&gt;
&lt;ingredient name="resourceBulletTip" count="80"/&gt;
&lt;ingredient name="resourceGunPowder" count="400"/&gt;
&lt;ingredient name="resourceBulletCasing" count="80"/&gt;
&lt;/recipe&gt;


&lt;recipe name="50calHP" count="1" craft_area="workbench" tags="learnable,workbenchCrafting"&gt;
&lt;ingredient name="resourceBulletTip" count="1"/&gt;
&lt;ingredient name="resourceGunPowder" count="7"/&gt;
&lt;ingredient name="resourceBulletCasing" count="1"/&gt;
&lt;/recipe&gt;

&lt;recipe name="Bundle50calHP" count="1" craft_time="240" craft_area="workbench" tags="learnable,workbenchCrafting"&gt;
&lt;ingredient name="resourceBulletTip" count="80"/&gt;
&lt;ingredient name="resourceGunPowder" count="560"/&gt;
&lt;ingredient name="resourceBulletCasing" count="80"/&gt;
&lt;/recipe&gt;

&lt;recipe name="50calAP" count="1" craft_area="workbench" tags="learnable,workbenchCrafting"&gt;
&lt;ingredient name="resourceBulletTip" count="1"/&gt;
&lt;ingredient name="resourceGunPowder" count="9"/&gt;
&lt;ingredient name="resourceBulletCasing" count="1"/&gt;
&lt;/recipe&gt;

&lt;recipe name="Bundle50calAP" count="1" craft_time="240" craft_area="workbench" tags="learnable,workbenchCrafting"&gt;
&lt;ingredient name="resourceBulletTip" count="80"/&gt;
&lt;ingredient name="resourceGunPowder" count="720"/&gt;
&lt;ingredient name="resourceBulletCasing" count="80"/&gt;
&lt;/recipe&gt;



&lt;/append&gt;
&lt;/LoopyBarrett&gt;

progression.xml

Code:

&lt;LoopyBarrett&gt;
&lt;append 
   xpath="/progression/perks/perk[@name='perkSniperAPAmmo']/effect_group"&gt;
       &lt;passive_effect name="RecipeTagUnlocked" operation="perc_add" level="1" value="1" tags="50calAP"/&gt;
&lt;/append&gt;

&lt;append 
   xpath="/progression/perks/perk[@name='perkSniperHPAmmo']/effect_group"&gt;
       &lt;passive_effect name="RecipeTagUnlocked" operation="perc_add" level="1" value="1" tags="50calHP"/&gt;
&lt;/append&gt;

&lt;append 
   xpath="/progression/perks/perk[@name='perkSniperComplete']/effect_group"&gt;
       &lt;passive_effect name="RecipeTagUnlocked" operation="perc_add" level="1" value="1" tags="Bundle50cal,Bundle50calHP,Bundle50calAP"/&gt;
&lt;/append&gt;

&lt;/LoopyBarrett&gt;

Edit; Updating code to main post

Guppycur · Feb 9, 2020

recipes.xml

thatloopydude · Feb 9, 2020

Added to the op. thanks btw

bdubyah · Feb 9, 2020

Check progression.xml. Needs something there as well.

Like, for the .44 AP:

Code:

&lt;item name="ammo44MagnumBulletAP"&gt;
&lt;property name="Extends" value="ammo44MagnumBulletBall"/&gt;
&lt;property name="DisplayType" value="ammoBulletAP"/&gt;
&lt;property name="EconomicValue" value="15"/&gt;
&lt;property name="DescriptionKey" value="ammoAPGroupDesc"/&gt;
&lt;property name="UnlockedBy" value="perkEnforcerAPAmmo"/&gt;
&lt;effect_group name="ammo44MagnumBulletAP" tiered="false"&gt;
	&lt;passive_effect name="EntityDamage" operation="base_set" value="80"/&gt;
	&lt;passive_effect name="BlockDamage" operation="base_set" value="14"/&gt;
	&lt;passive_effect name="TargetArmor" operation="perc_add" value="-.2"/&gt;
	&lt;display_value name="dTargetArmor" value="-.2"/&gt;
	&lt;passive_effect name="EntityPenetrationCount" operation="base_set" value="1"/&gt;
	&lt;display_value name="dTargetPenetration" value="1"/&gt;
	&lt;passive_effect name="DegradationPerUse" operation="perc_add" value=".3" tags="perkGunslinger"/&gt;
	&lt;display_value name="dDegradationPerUse" value=".3"/&gt;
&lt;/effect_group&gt;
&lt;/item&gt;

and in progression.xml, you have this:

Code:

&lt;perk name="perkEnforcerAPAmmo" parent="skillEnforcer" max_level="1" base_skill_point_cost="0" name_key="bookEnforcerAPAmmo" desc_key="perkEnforcerAPAmmoDesc" long_desc_key="perkEnforcerAPAmmoLongDesc"&gt;
	&lt;effect_group&gt;
		&lt;passive_effect name="RecipeTagUnlocked" operation="base_set" level="1" value="1" tags="ammo44MagnumBulletAP"/&gt;
	&lt;/effect_group&gt;
&lt;/perk&gt;

thatloopydude · Feb 9, 2020

Made a progression.xml and updated the op. would post the code here like you did @bdubyah but I haven;t the foggiest on how to do so...

thatloopydude · Feb 9, 2020

Fail at code box

bdubyah · Feb 10, 2020

In an advanced post, look for the # to post code.

One thing I can see that looks out of place is the

Code:

&lt;passive_effect name="RecipeTagUnlocked" operation="perc_add" level="1" value="1" tags="50calAP"/&gt;

should look like this I think:

Code:

&lt;passive_effect name="RecipeTagUnlocked" operation="base_set" level="1" value="1" tags="50calAP"/&gt;

bdubyah · Feb 10, 2020

Actually, now that I think about it, are you just using the perk to unlock ammo? Not add any effects?

If so, this is a book I have in my Nuka Colas mod to unlock their crafting recipe:

Code:

&lt;item name="bookNukaRecipes"&gt;
		&lt;property name="DescriptionKey" value="bookNukaRecipesDesc"/&gt;
		&lt;property name="CreativeMode" value="Player"/&gt;
		&lt;property name="HoldType" value="21"/&gt;
		&lt;property name="Meshfile" value="Items/Misc/bookPrefab"/&gt;
		&lt;property name="DropMeshfile" value="Items/Misc/sack_droppedPrefab"/&gt;
		&lt;property name="Material" value="Mpaper"/&gt;
		&lt;property name="CustomIcon" value="schematicMaster"/&gt; &lt;property name="CustomIconTint" value="D42F2F"/&gt;	
		&lt;property name="AltItemTypeIcon" value="book_read"/&gt;
		&lt;property name="Stacknumber" value="50"/&gt; 
		&lt;property name="EconomicValue" value="10000"/&gt;
		&lt;property name="SellableToTrader" value="true"/&gt;
		&lt;property name="FuelValue" value="4"/&gt;
		&lt;property name="Weight" value="40"/&gt;
		&lt;property name="Group" value="Books"/&gt;
		&lt;property name="Unlocks" value="resourceNukaBaseIngredients,drinkNukaCola,drinkNukaCherry,drinkNukaQuartz,drinkNukaQuantum"/&gt;
		&lt;property class="Action0"&gt;
			&lt;property name="Class" value="Eat"/&gt; 
			&lt;property name="Consume" value="true"/&gt; 
			&lt;property name="Delay" value="1.0"/&gt;
			&lt;property name="Use_time" value="..."/&gt;
			&lt;property name="ActionExpBonusMultiplier" value="0"/&gt; 
			&lt;property name="Sound_start" value="recipe_unlocked"/&gt;
		&lt;/property&gt;

		&lt;effect_group tiered="false"&gt;
			&lt;triggered_effect trigger="onSelfPrimaryActionEnd" action="GiveSkillExp" target="self" skill="attIntellect" experience="1000"/&gt;
			&lt;triggered_effect trigger="onSelfPrimaryActionEnd" action="ModifyCVar" cvar="resourceNukaBaseIngredients" operation="set" value="1"/&gt;
			&lt;triggered_effect trigger="onSelfPrimaryActionEnd" action="ModifyCVar" cvar="drinkNukaCola" operation="set" value="1"/&gt;
			&lt;triggered_effect trigger="onSelfPrimaryActionEnd" action="ModifyCVar" cvar="drinkNukaCherry" operation="set" value="1"/&gt;
			&lt;triggered_effect trigger="onSelfPrimaryActionEnd" action="ModifyCVar" cvar="drinkNukaQuartz" operation="set" value="1"/&gt;
			&lt;triggered_effect trigger="onSelfPrimaryActionEnd" action="ModifyCVar" cvar="drinkNukaQuantum" operation="set" value="1"/&gt;
			&lt;triggered_effect trigger="onSelfPrimaryActionEnd" action="ShowToolbeltMessage" target="self" message="Recipe Unlocked: Nuka Base Ingredients"/&gt;
			&lt;triggered_effect trigger="onSelfPrimaryActionEnd" action="ShowToolbeltMessage" target="self" message="Recipe Unlocked: Nuka Cola"/&gt;
			&lt;triggered_effect trigger="onSelfPrimaryActionEnd" action="ShowToolbeltMessage" target="self" message="Recipe Unlocked: Nuka Cherry"/&gt;
			&lt;triggered_effect trigger="onSelfPrimaryActionEnd" action="ShowToolbeltMessage" target="self" message="Recipe Unlocked: Nuka Quartz"/&gt;
			&lt;triggered_effect trigger="onSelfPrimaryActionEnd" action="ShowToolbeltMessage" target="self" message="Recipe Unlocked: Nuka Quantum"/&gt;
		&lt;/effect_group&gt;
	&lt;/item&gt;

Could try replacing the cvars to your ammo, and you'd need to add

Code:

tags="learnable"

to your recipes. Would that accomplish what you're wanting? Just unlocking recipes for ammo with a book? Or is there more to it? The perk method is how it looks like TFP handled it, but the book should do just fine for this. Should save you from having to mess with progression.

thatloopydude · Feb 10, 2020

Okay so here is the updated progression.xml I am still unable to craft the hp, ap, and bulk ammos

Code:

&lt;LoopyBarrett&gt;
&lt;append xpath="progression"&gt;

&lt;perk name="perkSniperAPAmmo" parent="skillSniper" max_level="1" base_skill_point_cost="0" name_key="bookSniperAPAmmo" desc_key="perkSniperAPAmmoDesc" long_desc_key="perkSniperAPAmmoLongDesc"&gt;
	&lt;effect_group&gt;
		&lt;passive_effect name="RecipeTagUnlocked" operation="base_set" level="1" value="1" tags="50calAP"/&gt;
	&lt;/effect_group&gt;
&lt;/perk&gt;
&lt;perk name="perkSniperHPAmmo" parent="skillSniper" max_level="1" base_skill_point_cost="0" name_key="bookSniperHPAmmo" desc_key="perkSniperHPAmmoDesc" long_desc_key="perkSniperHPAmmoLongDesc"&gt;
	&lt;effect_group&gt;
		&lt;passive_effect name="RecipeTagUnlocked" operation="base_set" level="1" value="1" tags="50calHP"/&gt;
	&lt;/effect_group&gt;
&lt;/perk&gt;
&lt;perk name="perkSniperComplete" parent="skillSniper" max_level="1" base_skill_point_cost="0" name_key="perkSniperCompleteName" desc_key="perkSniperCompleteDesc" long_desc_key="perkSniperCompleteLongDesc"&gt;
	&lt;effect_group&gt;
		&lt;passive_effect name="RecipeTagUnlocked" operation="base_set" level="1" value="1" tags="Bundle50cal,Bundle50calHP,Bundle50calAP"/&gt;
	&lt;/effect_group&gt;
&lt;/perk&gt;


&lt;/append&gt;
&lt;/LoopyBarrett&gt;

bdubyah · Feb 10, 2020

Just to check, is everything loading properly? If you hit F1 once in game, there's no yellow warnings?

thatloopydude · Feb 10, 2020

Yep, its loading fine as far as im aware and I'm not getting errors which is why I am stumped. no yellow or red for related to my mod.

bdubyah · Feb 10, 2020

Hmm. Yeah, I'm not entirely sure what part is wrong. Could try looking at the exported configs from the game save and see if it looks right.

bdubyah · Feb 10, 2020

Wait, I think I see it. Derp. Been a long night. Lol.

Are you just wanting to add your ammo to unlock with the vanilla bookSniperAPAmmo/bookSniperHPAmmo items?

If so, you'll need to be more specific in your xml. Like:

Code:

&lt;append xpath="/item/item[@name='bookSniperAPAmmo']/property[@name='Unlocks']/@value"&gt;,50calAP,Bundle50calAP&lt;/append&gt;

Code:

&lt;append xpath="/item/item[@name='bookSniperHPAmmo']/property[@name='Unlocks']/@value"&gt;,50calHP,Bundle50calHP&lt;/append&gt;

I *think* that should work for the items.xml part of it.

bdubyah · Feb 10, 2020

And for the progression side, something like:

Code:

&lt;append xpath="/progression/perks/perk[@name='perkSniperAPAmmo']/effect_group"&gt;
&lt;passive_effect name="RecipeTagUnlocked" operation="perc_add" level="1" value="1" tags="50calAP"/&gt;
&lt;/append&gt;

Code:

&lt;append xpath="/progression/perks/perk[@name='perkSniperHPAmmo']/effect_group"&gt;
&lt;passive_effect name="RecipeTagUnlocked" operation="perc_add" level="1" value="1" tags="50calHP"/&gt;
&lt;/append&gt;

Code:

&lt;append xpath="/progression/perks/perk[@name='perkSniperComplete']/effect_group"&gt;
&lt;passive_effect name="RecipeTagUnlocked" operation="perc_add" level="1" value="1" tags="Bundle50cal,Bundle50calHP,Bundle50calAP"/&gt;
&lt;/append&gt;

Again, I think that should work. I'm not super great at xpath by any means, so there might be some mistakes.

thatloopydude · Feb 10, 2020

So in my item.xml I replace this code

Code:

&lt;item name="bookSniperAPAmmo"&gt;
&lt;property name="Extends" value="bookSniperDamage"/&gt;
&lt;property name="DescriptionKey" value="perkSniperAPAmmoLongDesc"/&gt;
&lt;property name="Unlocks" value="perkSniperAPAmmo,50calAP,Bundle50calAP"/&gt;
&lt;effect_group tiered="false"&gt;
	&lt;triggered_effect trigger="onSelfPrimaryActionEnd" action="SetProgressionLevel" progression_name="perkSniperAPAmmo" level="-1"/&gt;
	&lt;triggered_effect trigger="onSelfPrimaryActionEnd" action="GiveExp" exp="50"/&gt;
	&lt;triggered_effect trigger="onSelfPrimaryActionEnd" action="SetProgressionLevel" progression_name="perkSniperComplete" level="-1"&gt;
		&lt;requirement name="PerksUnlocked" skill_name="skillSniper" operation="GTE" value="7"/&gt;&lt;/triggered_effect&gt;
	&lt;triggered_effect trigger="onSelfPrimaryActionEnd" action="PlaySound" sound="read_skillbook_final" play_in_head="true"&gt;
		&lt;requirement name="PerksUnlocked" skill_name="skillSniper" operation="GTE" value="7"/&gt;&lt;/triggered_effect&gt;
&lt;/effect_group&gt;
&lt;/item&gt;



&lt;item name="bookSniperHPAmmo"&gt;
&lt;property name="Extends" value="bookSniperDamage"/&gt;
&lt;property name="DescriptionKey" value="perkSniperHPAmmoLongDesc"/&gt;
&lt;property name="Unlocks" value="perkSniperHPAmmo,50calHP,Bundle50calHP"/&gt;
&lt;effect_group tiered="false"&gt;
	&lt;triggered_effect trigger="onSelfPrimaryActionEnd" action="SetProgressionLevel" progression_name="perkSniperHPAmmo" level="-1"/&gt;
	&lt;triggered_effect trigger="onSelfPrimaryActionEnd" action="GiveExp" exp="50"/&gt;
	&lt;triggered_effect trigger="onSelfPrimaryActionEnd" action="SetProgressionLevel" progression_name="perkSniperComplete" level="-1"&gt;
		&lt;requirement name="PerksUnlocked" skill_name="skillSniper" operation="GTE" value="7"/&gt;&lt;/triggered_effect&gt;
	&lt;triggered_effect trigger="onSelfPrimaryActionEnd" action="PlaySound" sound="read_skillbook_final" play_in_head="true"&gt;
		&lt;requirement name="PerksUnlocked" skill_name="skillSniper" operation="GTE" value="7"/&gt;&lt;/triggered_effect&gt;
&lt;/effect_group&gt;
&lt;/item&gt;

with the code you posted above? with the extra appends? Sorry I am 100% unversed in modding and this is my first time attempting something like this

bdubyah · Feb 10, 2020

Yeah. If you're editing something that already exists, you have to target certain parts of it. The general append you're doing would try and add an entirely new item.

thatloopydude · Feb 10, 2020

Okay, so I after editing the two xml files I now get a yellow text "WRN XML patch for "items.xml" from mod "Loopy's Barrett M82" did not apply: <append xpath="/item/item[@name=bookSniperAPAmmo]/property[@name=Unlocks]/@value" for the ap and hp append

Items.xml http://bit.ly/2ScMOKl

Progression

Code:

&lt;LoopyBarrett&gt;
&lt;append 
   xpath="/progression/perks/perk[@name='perkSniperAPAmmo']/effect_group"&gt;
       &lt;passive_effect name="RecipeTagUnlocked" operation="perc_add" level="1" value="1" tags="50calAP"/&gt;
&lt;/append&gt;

&lt;append 
   xpath="/progression/perks/perk[@name='perkSniperHPAmmo']/effect_group"&gt;
       &lt;passive_effect name="RecipeTagUnlocked" operation="perc_add" level="1" value="1" tags="50calHP"/&gt;
&lt;/append&gt;

&lt;append 
   xpath="/progression/perks/perk[@name='perkSniperComplete']/effect_group"&gt;
       &lt;passive_effect name="RecipeTagUnlocked" operation="perc_add" level="1" value="1" tags="Bundle50cal,Bundle50calHP,Bundle50calAP"/&gt;
&lt;/append&gt;

&lt;/LoopyBarrett&gt;

Still unable to craft. Im prob doing something wrong :miserable: :miserable:

Edit Yes i am just trying to add my hp, ap, and bulk ammos to the sniper book tree that unlocks the 7.62 counterparts

bdubyah · Feb 10, 2020

Just posting to say we got this issue sorted out.

Stranded_Napkin · Feb 11, 2020

I think that I've found it.

<append xpath="/item/item[@name=bookSniperAPAmmo]/property[@name=Unlocks]/@value">,50calAP,Bundle50calAP</append>

should be:

<append xpath="/items/item[@name=bookSniperAPAmmo]/property[@name=Unlocks]/@value">,50calAP,Bundle50calAP</append>

You forgot the 's' on items. It's looking for item.xml instead of items.xml. With that fixed, it should append the book and subsequently allow you to unlock the recipes. This might have been already mentioned, though the above post that looked like they were mentioning this didn't specifically mention the correction.

Oops. Didn't realize it got fixed already. Oh well.

Help a new modder out! Thanks!!

thatloopydude

New member

Guppycur

Well-known member

thatloopydude

New member

bdubyah

Well-known member

thatloopydude

New member

thatloopydude

New member

bdubyah

Well-known member

bdubyah

Well-known member

thatloopydude

New member

bdubyah

Well-known member

thatloopydude

New member

bdubyah

Well-known member

bdubyah

Well-known member

bdubyah

Well-known member

thatloopydude

New member

bdubyah

Well-known member

thatloopydude

New member

bdubyah

Well-known member

Stranded_Napkin

New member