• Mods are now organized as resources. Use the Mods link above to browse for or submit a mod, tool, or prefab.

    The TFP Official Modding Forum Policy establishes the rules and guidelines for mod creators and mod users.

2.5 broke simple bike mod

W

Werecow

Refugee
Found an abandoned mod to increase bike speed quite a while ago. I've since modded the XML to fit the various version changes.
It has all worked quite well until 2.5 I can go into creative mode and give myself the mod, but it absolutely will not install into the bike. It doesn't appear with the green around it either to signify that its a related mod.

Item_modifiers.XML:
<config>
<append xpath="/item_modifiers">
<item_modifier name="modBikeSpeedBoost" installable_tags="bicycle" modifier_tags="speed" blocked_tags="noMods" type="attachment">
<property name="Extends" value="modGeneralMaster"/>
<property name="DescriptionKey" value="BikeBoostDesc"/>
<property name="TraderStageTemplate" value="modsTier1"/>
<property name="CustomIconTint" value="#4f3746"/>
<property name="TintColor" value="#4f3746"/>
<property name="CustomIcon" value="modGunBowPolymerString"/>
<effect_group tiered="false">
<passive_effect name="VehicleMotorTorquePer" operation="perc_add" value=".30"/>
<passive_effect name="VehicleVelocityMaxPer" operation="perc_add" value=".48"/>
</effect_group>
</item_modifier>
</append>
</config>
---------------------
Items.XML :
<configs>
<set xpath="/items/item[@name='vehicleBicyclePlaceable']/property[@name='Tags']/@value">vehicle,bicycle</set>
</configs>
---------------------
ModInfo.XML :
<xml>
<Name value="BikeSpeedBoost"/>
<DisplayName value="BikeSpeedBoost"/>
<Description value="Bike Speed Boost"/>
<Author value="x"/>
<Version value="2.5"/>
</xml>

Not sure what I've missed. Any assistance is greatly appreciated!
 
Not sure why yours not working. I put what you posted into a mod and tested it on 2.5(b27) and it worked fine.
the only thing I would comment about is I would change the Items.XML from a <Set to a <csv as there are some more tags in vehicleBicyclePlaceable and if you want other mods to work in the bike, you don't want to remove them.
eg other tags: vlight,vstorage,canHaveCosmetic

<csv xpath="/items/item[@name='vehicleBicyclePlaceable']/property[@name='Tags']/@value" op="Add">bicycle</csv>
 
Just a thought after a bit of sleep.do you have any other mods running that alter the vehicleBicyclePlaceable in items.XML. because if they also use the set xpath and run after this one, then they will override this mods tags.

have you looked at the save game config dump of both changed XMLs to confirm the game was actually running with them correctly inserted?
 
Appreciate you trying this out! I do have the wasteland mod and that may very well be the culprit. I'll try creating a new world without and see if that works. Many thanks for your insight and taking the time to test this yourself.
 
Ok. downloaded the wasteland mod and see your problem. first on their page it says.
"This mod is an overhaul and will likely not work with other mods. If you are using other mods and have errors, remove the other mods and try again before coming here and saying the mod is broken." (it also means other mods may not work with it).

this is because overhaul mods normally overwrite everything. I was surprised you could even see the bicycle mod let alone not put it on. so I had a look at the mod to see why.

there Item_modifiers.XML only sets and overrides specific modifiers so doesn't touch yours. but Items.XML does the normal and sets (overrides) the whole file, so it overwrites your bike add on.

when you start the game if you hit F1 and scroll to the top it shows the mods being added and you will see the order, I'm betting yours is before the wastelands. you will need to change the name of the windows file of your mod so it is alphabetically higher than "The_Waseland" so it is installed after and not overridden.

and I would still change the set in yours to the CSV as there's still has the vehicleBicyclePlaceable as
<property name="Tags" value="vehicle,vlight,vstorage,canHaveCosmetic"/>
and yours is setting it to "vehicle,bicycle" losing 3 tags so other things will brake. the cvs will change it to "vehicle,vlight,vstorage,canHaveCosmetic,bicycle" so all will work together.

PS. you could just change your set to include them. but better to add it in case you add other mods that have same issue.
 
I wasn't sure about the alphabetically higher and changed it to have a 0 in front. That didn't work so I put a z in front which did finally work after tinkering around.
I'm not a mod developer, just someone who played around with an outdated mod. Is there a My First 7D2D mod tutorial rolling around anywhere?

Thanks so much for your assistance!!
 
You must log in or register to reply here.
Back
Top