Question regarding adding effects to Armor

[Darkxenoth]

So I'm wanting to add some effects to the commando armor pieces, as I like how they look, but didn't want to lose out on the effects of some other armors. Where all do I need to change to make this work? I've made changes to items.xml and ui_display.xml; but not sure if I missed something...

Here's a look at some of the changes to items.xml:

<remove xpath="items/item[@name='armorCommandoHelmet']" />
<insertAfter xpath="items/item[@name='armorRangerBoots']">
<item name="armorCommandoHelmet">
<property name="Extends" value="armorMediumMaster" param1="CustomIcon"/>
<property name="DescriptionKey" value="armorCommandoHelmetDesc"/>
<property name="DisplayType" value="armorCommandoHelmet"/>
<property name="ArmorGroup" value="groupCommando"/>
<property name="Tags" value="head,armor,armorHead,mediumArmor,mediumArmorPenalty,canHaveCosmetic,mediumArmorDeg,armorMediumSkill,armorCommandoBonus"/>
<property name="EquipSlot" value="Head"/>
<property name="SoundPickup" value="headwear_cloth_grab"/>
<property name="SoundPlace" value="headwear_cloth_place"/>
<effect_group name="CommandoHelmet">
<passive_effect name="ModSlots" operation="base_set" value="1,1,2,2,3,4" tier="1,2,3,4,5,6"/>
<passive_effect name="ModPowerBonus" operation="base_add" value="300" tags="EconomicValue"/>
<passive_effect name="PhysicalDamageResist" operation="base_add" value="13,17.3" tier="1,6"/>
<passive_effect name="PhysicalDamageResist" operation="base_add" value="-.2,.2"/>
<passive_effect name="ElementalDamageResist" operation="base_add" value="13,17.3" tier="1,6" tags="heat,electrical"/>
<passive_effect name="ElementalDamageResist" operation="base_add" value="-.2,.2"/>
<passive_effect name="BuffResistance" operation="base_add" value="0.043,0.053" tags="buffFatiguedTrigger,buffArmSprainedCHTrigger,buffLegSprainedCHTrigger,buffAbrasionCatch,buffLaceration,buffInfectionCatch,buffInjuryStunned01CHTrigger,buffInjuryBleedingTwo,buffInjuryBleedingBarbedWire"/>
<passive_effect name="DegradationMax" operation="base_set" value="250,500" tier="1,6"/>
<passive_effect name="DegradationPerUse" operation="base_set" value="1" tags="mediumArmorDeg"/>
<passive_effect name="HypothermalResist" operation="base_add" value="20"/>
<passive_effect name="HyperthermalResist" operation="base_add" value="20"/>

<passive_effect name="Mobility" operation="perc_add" value="-.049"/> <!-- Set .001 lower to resolve floating point rounding issues -->
<passive_effect name="StaminaChangeOT" operation="perc_add" value="-.0281" tags="walking"/>
<passive_effect name="StaminaChangeOT" operation="perc_add" value="-.0562" tags="running"/>
<display_value name="dStaminaChangeOT" value="-.56"/>
<passive_effect name="NoiseMultiplier" operation="perc_add" value=".1"/>
<display_value name="dNoiseMultiplier" value=".1"/>
<!-- Arkx added Exp Gain increase -->
<passive_effect name="PlayerExpGain" operation="perc_add" value=".05,.1,.15,.2,.25,.5" tier="1,2,3,4,5,6"/>
<display_value name="dPlayerExpGain" value=".05,.1,.15,.2,.25,.5" tier="1,2,3,4,5,6"/>
</effect_group>

<effect_group>
<passive_effect name="BuffResistance" operation="base_add" value=".02,.04,.06,.08,.1,.2" tier="1,2,3,4,5,6" tags="buffInjuryStunned01"/>
<display_value name="dStunResist" value=".02,.04,.06,.08,.1,.2" tier="1,2,3,4,5,6"/>
</effect_group>

<property class="SDCS">
<property name="HeadGearName" value="Commando"/>
<property name="TransformName" value="head"/>
<property name="Excludes" value=""/>
<property name="HairMaskType" value="Hat"/>
</property>
</item>
</insertAfter>




and to ui_display.xml

<!-- display the exp gain added to the Commando Helmet -->
<append xpath="ui_display_info/item_display/item_display_info[@display_type='armorCommandoHelmet']">
<display_entry name="dPlayerExpGain" title_key="statShowPlayerExpGain" display_type="Percent" display_leading_plus="true"/>
</append>




Would this work as is, or would I need to change it? Can I clean this up easily (specifically the items.xml)?

-edit- I ran it in-game to check, and I didn't notice any errors or warnings in the log; and it does show xp gain (or whatever it actually shows up as) in addition to the stun resist on the helm. I'm just not sure it actually works... tried doing a few things without the helm, then did the same things with the helm and didn't see a difference in the xp gains that popup.

-edit2- I'm pretty sure its working... I got more time to test it, and tried doing stuff worth more xp, and it definitely increases xp gain; just needs to be able to actually get a percentage as a whole number I guess.